Fix crash on include cursors without source file (fixes CUDA builds)#30
Open
jrhemstad wants to merge 1 commit intobkryza:mainfrom
Open
Fix crash on include cursors without source file (fixes CUDA builds)#30jrhemstad wants to merge 1 commit intobkryza:mainfrom
jrhemstad wants to merge 1 commit intobkryza:mainfrom
Conversation
Skip inclusion directives when clang_getFileLocation returns a null source_file handle (seen for built-in CUDA headers), preventing std::string construction from null while preserving normal include graph generation.
Owner
|
@jrhemstad Can you run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #29
This PR adds a check to skip include directives when
clang_getFileLocationreturns a nullsource_filehandle, preventing std::string construction from null while preserving normal include graph generation.Example of the warning log message: